Add an inline platform check for ExecCondition of gnoi-shutdown.service#395
Merged
BYGX-wcr merged 3 commits intoJun 19, 2026
Merged
Conversation
Signed-off-by: BYGX-wcr <wcr@live.cn>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: BYGX-wcr <wcr@live.cn>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
reviewed
Jun 18, 2026
| [Service] | ||
| Type=simple | ||
| ExecStart=/usr/bin/python3 /usr/local/bin/gnoi_shutdown_daemon.py | ||
| ExecCondition=/usr/bin/python3 -c "import sys; from sonic_py_common import device_info; from utilities_common.chassis import is_dpu; sys.exit(0 if (device_info.is_smartswitch() and not is_dpu()) else 1)" |
Contributor
There was a problem hiding this comment.
is_dpu is also available in device_info
Signed-off-by: BYGX-wcr <wcr@live.cn>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zjswhhh
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an inline platform check for ExecCondition of gnoi-shutdown.service so that the gnoi-shutdown.service is skipped on non-smartswitch NPU platforms.
Fix issue: #27975