Parameterize gNMI CONFIG DB tests with different VRFs#20456
Open
spandan-nexthop wants to merge 1 commit into
Open
Parameterize gNMI CONFIG DB tests with different VRFs#20456spandan-nexthop wants to merge 1 commit into
spandan-nexthop wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
9 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
spandan-nexthop
requested review from
a team,
wangxin and
yxieca
as code owners
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
645f3ac to
be3a2b2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@qiluo-msft @sneelam20 @anand-kumar-subramanian @seiferteric Adding sonic-gnmi maintainers for viz |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
be3a2b2 to
8eb37b5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
8eb37b5 to
9bf6f80
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
9bf6f80 to
0364fe0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
0364fe0 to
07ef202
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@qiluo-msft @hdwhdw @sneelam20 @anand-kumar-subramanian @seiferteric can we get a look at this as we are targeting the 202605 release and it is coming up. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1124996: ✅Stage Test:
|
Contributor
|
Hi @spandan-nexthop, this PR currently has merge conflicts with the target branch. Could you confirm whether it's still relevant/active? If so, please rebase and resolve the conflicts, and we'll review it. Thanks! |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
a755b0c to
d995e1a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
/azpw retry |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
Retrying failed(or canceled) stages in build 1136469: ✅Stage Test:
|
bhouse-nexthop
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 15, 2026
#### What I did Restarting gNMI and Telemetry services if the VRF is changed via GCU. Fixes: sonic-net/sonic-gnmi#504 Related PRs: - sonic-net/sonic-gnmi#503 - sonic-net/sonic-buildimage#23867 - sonic-net/sonic-mgmt#20456 #### How I did it This change adds gnmi and telemetry validators to check for a change in VRF and restarts the services accordingly. #### How to verify it Added gNMI and Telemetry service validator tests have been passing. #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed) Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
Contributor
|
Hi @spandan-nexthop, CI is failing on this PR (it ran on the current commit), so a re-run won't help — could you take a look at the failures and fix them? Once CI is green we'll proceed with review. Thanks! |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
d995e1a to
a9cb184
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@StormLiangMS @wangxin @yxieca A user wants to merge changes to the conditional mark files into |
Collaborator
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
hdwhdw
requested changes
Jun 18, 2026
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
a9cb184 to
8d2a4d1
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
8d2a4d1 to
e0f569b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ct VRF binding of gNMI listener Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
e0f569b to
ce8c53b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener
Summary:
Fixes sonic-net/sonic-gnmi#504
Depends on:
Type of change
Back port request
Approach
What is the motivation for this PR?
To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867
How did you do it?
Parameterized
test_gnmi_configdb.pywithdefault,mgmt_vrfand a custom VRF scenario.How did you verify/test it?
Manual verification of relevant changes are already done with the
sonic-buildimagechanges.The updated tests ran successfully in local setup.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
Any testbed works for the default and
mvrftest cases.Custom non-mgmt VRF testcase requires a
t0topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF.Documentation
NA
A picture of a cute animal (not mandatory but encouraged)