[infra] Run sanity checks in the parallel fixture manager#22311
Open
lolyu wants to merge 3 commits into
Open
Conversation
Collaborator
|
/azp run |
github-actions
Bot
requested review from
cyw233,
theasianpianist and
wangxin
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
force-pushed
the
pfm_sanity_check
branch
from
5058799 to
6f7005c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
commented
Mar 26, 2026
lolyu
left a comment
lolyu
left a comment
Collaborator
Author
There was a problem hiding this comment.
📊 Review Summary — [infra] Run sanity checks in the parallel fixture manager
Nice perf improvement — sanity_check_full cut from ~1m10s to ~35s on dualtor-aa. Clean migration from SafeThreadPoolExecutor to ParallelCoordinator.
✅ Strengths
- Clear before/after timing data
- Clean removal of
SafeThreadPoolExecutorimport - Backward-compatible
parallel_manager=Nonedefault inrecover_on_sanity_check_failure
Findings
⚠️ parallel_manager=Nonenot guarded indo_checks— could crash if called without it⚠️ Variable shadowing:duthostbecomes a string inprint_logsloop- 📝
check_fixture.__name__mutation could leak as side effect - 💡
future.result()exceptions not caught — could propagate unhandled
See inline comments for details and suggested fixes.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Run the sanity checks in the parallel fixture manager to reduce runtime.
This depends on #21949.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
As the motivation.
How did you verify/test it?
Run on
dualtor-aatestbed:Before:
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation