[conftest]: Honor skip_check_dut_health marker in yang_validation_check#25263
Merged
yejianquan merged 1 commit intoJun 15, 2026
Conversation
Signed-off-by: sakshamkhurana <sakkhurana@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
12 tasks
auspham
approved these changes
Jun 11, 2026
auspham
left a comment
Contributor
There was a problem hiding this comment.
Approved as if the test is marked as skip_dut_health, we should tolerate yang validation as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Make the autouse
yang_validation_checkmodule-scoped fixture intests/conftest.pyhonor the
skip_check_dut_healthmarker, matching the existing precedent set bycore_dump_and_config_checkin the same file.Today,
yang_validation_checkruns unconditionally for every test module, includingmaintenance / recovery / reboot / upgrade / HA modules that intentionally operate
against a transiently unreachable or unhealthy DUT. This causes flakes, see below:
Summary:
Fixes Flaky test
Type of change
Back port request
Approach
What is the motivation for this PR?
test_posttest::test_restore_container_autorestart[vlab-03](and several othermaintenance modules) is flaky on PR validation runs.
How did you do it?
Added an early-yield gate inside
yang_validation_check, immediately after theexisting
--skip_yangflag handling, that follows the same idiom used bycore_dump_and_config_check(tests/conftest.py:3117-3119):Any platform specific information?
N/a
Supported testbed topology if it's a new test case?
N/a
Documentation
N/a