conditional_mark: skip test_loopback_filter and test_acl_egress_drop on Nokia IXR7220-H6-128#25320
Open
bingwang-ms wants to merge 1 commit into
Open
conditional_mark: skip test_loopback_filter and test_acl_egress_drop on Nokia IXR7220-H6-128#25320bingwang-ms wants to merge 1 commit into
bingwang-ms wants to merge 1 commit into
Conversation
…on Nokia IXR7220-H6-128 Nokia IXR7220-H6-128 SAI has two unimplemented features: 1. Loopback filter: packets arriving on an interface where the route to the destination also exits are not dropped. test_loopback_filter sends 1000 packets and expects RX_DRP to increment by 1000, but Nokia increments by 0 (rif_members) or 1 (port_channel_members). 2. Egress ACL on LAG: SAI logs show "Egress ACL Bind to LAG is not implemented yet" causing test setup to fail with LogAnalyzerError (expected ACL rule creation log missing). Skip both tests on x86_64-nokia_ixr7220_h6_128-r0 until the SAI layer implements these features. Verified by running drop_packets/test_drop_counters.py on testbed vms13-lt2-nokia-th6-1: 40 passed, 58 skipped, 2 failed, 6 errors (failures are exactly these two test cases). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bing Wang <bingwang@microsoft.com>
Collaborator
|
/azp run |
github-actions
Bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add explicit Nokia IXR7220-H6-128 skip conditions for two drop_packets tests that fail on Nokia hardware due to SAI limitations:
test_loopback_filter: Nokia SAI does not implement loopback filter drop. When a packet arrives on interface X and the route to the destination also exits on interface X, Nokia forwards the packet instead of dropping it. Test sends 1000 packets expecting
RX_DRPto increment, but Nokia keeps it at 0 (rif_members) or 1 (port_channel_members). Note:tests_mark_conditions_drop_packets.yamlalready has an unconditional skip for this test for all platforms — this PR adds a Nokia-specific explicit entry for documentation clarity.test_acl_egress_drop: Nokia TH6 uses a Broadcom ASIC internally, and SAI logs
Egress ACL Bind to LAG is not implemented yetcausing the test setup to fail.tests_mark_conditions_drop_packets.yamlalready skips this forasic_type in ['broadcom']which covers Nokia. This PR adds a Nokia-platform-specific entry as explicit documentation.Also fixes a pre-existing alphabetical sort violation in the
dhcp_relaysection (moveddhcp_relay/.*\[.*sonic-relay-agentto its correct position).Type of change
Back port request
Approach
What is the motivation for this PR?
Nokia IXR7220-H6-128 nightly tests on testbed
vms13-lt2-nokia-th6-1produce failures and errors for these two test cases due to SAI limitations.How did you do it?
Added platform-specific skip conditions for
x86_64-nokia_ixr7220_h6_128-r0intests_mark_conditions.yaml.How did you verify/test it?
Ran
drop_packets/test_drop_counters.pyon testbedvms13-lt2-nokia-th6-1. Before this fix: 40 passed, 58 skipped, 2 failed (test_loopback_filter), 6 errors (test_acl_egress_drop×4 setup/teardown + 2 unrelated teardown monitoring false positives).Any platform specific information?
Nokia IXR7220-H6-128 only.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A