[action] [PR:23793] [Qos]UpdateFeatureState func call in teardown fixed to run from host#25321
Merged
Merged
Conversation
…onic-net#23793) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Correcting the updateFeatureState func call in stopServices teardown path to run from host ( PR sonic-net#18884 ), Summary: Fixes # (issue) Failure in multi-dut qos test with error -TypeError: SonicAsic.command() got an unexpected keyword argument 'module_ignore_errors' ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? Failure in multi-dut qos test with error -TypeError: SonicAsic.command() got an unexpected keyword argument 'module_ignore_errors' #### How did you do it? the updateFeatureState func call takes the Sonic_host as argument. Hence corrected the calling function #### How did you verify/test it? Executed the qos tests & verified the results #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: ansrajpu <anshu.rajput@nokia.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
12 tasks
Collaborator
Author
|
Original PR: #23793 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
Author
|
This cherry pick PR has been opened for more than 3 days. The mssonicbld will attempt to retry. ---Powered by SONiC BuildBot
|
Collaborator
Author
|
/azpw retry |
Collaborator
Author
|
Retrying failed(or canceled) jobs... |
Collaborator
Author
|
Retrying failed(or canceled) stages in build 1136478: ✅Stage Pre_test:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Correcting the updateFeatureState func call in stopServices teardown path to run from host ( PR #18884 ),
Summary:
Fixes # (issue)
Failure in multi-dut qos test with error -TypeError: SonicAsic.command() got an unexpected keyword argument 'module_ignore_errors'
Type of change
Back port request
Approach
What is the motivation for this PR?
Failure in multi-dut qos test with error -TypeError: SonicAsic.command() got an unexpected keyword argument 'module_ignore_errors'
How did you do it?
the updateFeatureState func call takes the Sonic_host as argument. Hence corrected the calling function
How did you verify/test it?
Executed the qos tests & verified the results
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation