Skip to content

Fix loganalyzer to ignore port attr errors with any exit code#25458

Merged
bingwang-ms merged 1 commit into
sonic-net:masterfrom
deerao02:fix/loganalyzer-port-attr-ignore
Jun 18, 2026
Merged

Fix loganalyzer to ignore port attr errors with any exit code#25458
bingwang-ms merged 1 commit into
sonic-net:masterfrom
deerao02:fix/loganalyzer-port-attr-ignore

Conversation

@deerao02

@deerao02 deerao02 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Description of PR

The existing ignore pattern only matched 'Failed to get port attr' errors with exit code -2. Other negative exit codes (e.g., -6) from syncd were still flagged as test failures. Generalize the pattern to match any negative exit code (-\d+).
The qos.test_qos_sai.TestQosSai.testParameter test consistently fails on teardown on Arista-7060X6-64PE-P32O64 (LT2 topology) because the loganalyzer catches syncd errors like:

ERR syncd#syncd: :- collectData: Failed to get port attr for VID 0x100000000000b, RID:0x100000055: -8

An ignore rule already exists in loganalyzer_common_ignore.txt but it only matches exit code -2. On this platform, syncd returns -8, causing 16 spurious matches per run and a 0% pass rate on LT2 topology across all OS versions (20251110.23 through 20251110.30).

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202311
  • 202405
  • 202411
  • 202505
  • 202511
  • 202512
  • 202605

Approach

What is the motivation for this PR?

The existing ignore pattern only matched 'Failed to get port attr' errors with exit code -2. Other negative exit codes (e.g., -6) from syncd were still flagged as test failures.

How did you do it?

Changed the regex in loganalyzer_common_ignore.txt from:

r, ".* ERR syncd\d*#syncd: :- collectData: Failed to get port attr for VID 0x[0-9a-fA-F]+, RID:0x[0-9a-fA-F]+: -2.*"

to:

r, ".* ERR syncd\d*#syncd: :- collectData: Failed to get port attr for VID 0x[0-9a-fA-F]+, RID:0x[0-9a-fA-F]+: -\d+.*"

This matches any negative return code from collectData, which is a benign platform-specific log message that does not indicate a real test failure.

How did you verify/test it?

Verified the updated regex matches the actual syslog lines from the failing test runs:
bash
echo 'ERR syncd#syncd: :- collectData: Failed to get port attr for VID 0x100000000000b, RID:0x100000055: -8' | grep -P 'collectData: Failed to get port attr for VID 0x[0-9a-fA-F]+, RID:0x[0-9a-fA-F]+: -\d+'

Any platform specific information?

Consistently reproduced on Arista-7060X6-64PE-P32O64 (Broadcom ASIC, LT2 topology). The  -8  return code appears specific to this hardware SKU.

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

The existing ignore pattern only matched 'Failed to get port attr' errors
with exit code -2. Other negative exit codes (e.g., -6) from syncd were
still flagged as test failures. Generalize the pattern to match any
negative exit code (-\d+).

Signed-off-by: Deeksha Rao <deerao@microsoft.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms

Copy link
Copy Markdown
Collaborator

Please fill PR description properly

@bingwang-ms bingwang-ms merged commit 205b4d8 into sonic-net:master Jun 18, 2026
26 checks passed
@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202511: #25470

@mssonicbld

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202512: Azure/sonic-mgmt.msft#1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants