[platform_tests] Skip unavailable SFP thermal thresholds#25485
Open
xwjiang-ms wants to merge 1 commit into
Open
[platform_tests] Skip unavailable SFP thermal thresholds#25485xwjiang-ms wants to merge 1 commit into
xwjiang-ms wants to merge 1 commit into
Conversation
Signed-off-by: xwjiang-ms <xiaweijiang@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
This PR has backport request for branch(es): 202605. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The SFP thermal threshold test treats N/A values in TRANSCEIVER_DOM_THRESHOLD as available threshold data. On platforms where xcvrd publishes threshold keys but all threshold fields are N/A, the test compares zero numeric rows and fails with Only 0/0 SFP rows had thresholds matching TRANSCEIVER_DOM_THRESHOLD.
How I did it
Normalize N/A threshold field values to missing data in _get_dom_threshold_data, allowing the existing No TRANSCEIVER_DOM_THRESHOLD data available skip path when no numeric thresholds exist.
How to verify it
Back port request