fix test_bgp_facts_ipv6_only on modular with different linecards#25499
Open
peterbailey-arista wants to merge 1 commit into
Open
fix test_bgp_facts_ipv6_only on modular with different linecards#25499peterbailey-arista wants to merge 1 commit into
peterbailey-arista wants to merge 1 commit into
Conversation
The test incorrectly uses `duthost` to check if the current front end host is multi-asic or not. When the thread starts for each front end host `duthost`` will have been defined by the loop but it will not necessarily be the correct host when verify_bgp_facts is called. The test fails on a modular where the linecards have different numbers of asics because containers on a multi-asic LC are not the same as containers on a single-asic LC. The loop re-assigns duthost each iteration but each thread is sharing that same object. Signed-off-by: Peter <peterbailey@arista.com>
Collaborator
|
/azp run |
peterbailey-arista
force-pushed
the
fix-test-verify-bgp-facts
branch
from
f91c79e to
7c0a65c
Compare
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
added
Request for 202511 branch
Collaborator
|
This PR has backport request for branch(es): 202511,202605. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The test incorrectly uses
duthostto check if the current front end host is multi-asic or not. When the thread starts for each front end host `duthost`` will have been defined by the loop but it will not necessarily be the correct host when verify_bgp_facts is called.The test fails on a modular where the linecards have different numbers of asics because containers on a multi-asic LC are not the same as containers on a single-asic LC. The loop re-assigns duthost each iteration but each thread is sharing that same object.
Fix is to use the passed
dutobject.Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test failure seen on modular chassis.
How did you do it?
Fix is to use the passed
dutobject instead ofduthostobject defined by the loop.How did you verify/test it?
ran
ip/test_mgmt_ipv6_only.pywith the change.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation