Skip to content

Fix test_ha_npu_process_crash for NPU-driven HA #25503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BYGX-wcr wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −7
Open

Fix test_ha_npu_process_crash for NPU-driven HA #25503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b25258
Adapt test_ha_npu_process_crash for NPU-driven HA
BYGX-wcr Jun 19, 2026
5df477f
Fix pre-commit formatting check failures
BYGX-wcr Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions tests/ha/test_ha_npu_process_crash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,7 @@ def _run(
)

# Wait for both DUTs to reach their initial expected HA states before
# the crash. Both DUTs show "active" in local_acked_asic_ha_state
# because the DPU HA dataplane operates in active/active mode.
# the crash.
logger.info("Waiting for initial HA states to stabilize before crash")
verify_ha_state_converged(
crash_duthost, crash_scope_key, expected_ha_state_after_crash
Expand Down Expand Up @@ -460,7 +459,8 @@ def test_crash_active_npu_traffic_on_active(
localhost, ptfhost,
activate_dash_ha_from_json,
primary_vdpu_key,
standby_vdpu_key
standby_vdpu_key,
ha_owner
):
self._run(
process_name=process_name, container=container,
Expand All @@ -469,7 +469,7 @@ def test_crash_active_npu_traffic_on_active(
expected_ha_state_after_crash="active",
verify_duthost=standby_dut,
verify_scope_key=standby_vdpu_key,
expected_ha_state_verify="active",
expected_ha_state_verify="active" if ha_owner == "dpu" else "standby",
ptfadapter=ptfadapter, dash_pl_config=dash_pl_config,
traffic_dut_index=0, duthosts=duthosts,
localhost=localhost, ptfhost=ptfhost,
Expand All @@ -484,6 +484,7 @@ def test_crash_active_npu_traffic_on_standby(
ptfadapter, dash_pl_config,
localhost, ptfhost,
activate_dash_ha_from_json,
ha_owner
):
self._run(
process_name=process_name, container=container,
Expand All @@ -492,7 +493,7 @@ def test_crash_active_npu_traffic_on_standby(
expected_ha_state_after_crash="active",
verify_duthost=standby_dut,
verify_scope_key=standby_vdpu_key,
expected_ha_state_verify="active",
expected_ha_state_verify="active" if ha_owner == "dpu" else "standby",
ptfadapter=ptfadapter, dash_pl_config=dash_pl_config,
traffic_dut_index=1, duthosts=duthosts,
localhost=localhost, ptfhost=ptfhost,
Expand All @@ -507,12 +508,13 @@ def test_crash_standby_npu_traffic_on_active(
ptfadapter, dash_pl_config,
localhost, ptfhost,
activate_dash_ha_from_json,
ha_owner
):
self._run(
process_name=process_name, container=container,
crash_duthost=standby_dut,
crash_scope_key=standby_vdpu_key,
expected_ha_state_after_crash="active",
expected_ha_state_after_crash="active" if ha_owner == "dpu" else "standby",
verify_duthost=primary_dut,
verify_scope_key=primary_vdpu_key,
expected_ha_state_verify="active",
Expand All @@ -530,12 +532,13 @@ def test_crash_standby_npu_traffic_on_standby(
ptfadapter, dash_pl_config,
localhost, ptfhost,
activate_dash_ha_from_json,
ha_owner
):
self._run(
process_name=process_name, container=container,
crash_duthost=standby_dut,
crash_scope_key=standby_vdpu_key,
expected_ha_state_after_crash="active",
expected_ha_state_after_crash="active" if ha_owner == "dpu" else "standby",
verify_duthost=primary_dut,
verify_scope_key=primary_vdpu_key,
expected_ha_state_verify="active",
Expand Down
Loading