[pc] Skip lacp_rate test on Nokia physical platforms#25513
Open
bingwang-ms wants to merge 1 commit into
Open
Conversation
Nokia physical hardware (e.g., Nokia-IXR7220-H6-O256) does not honor LACP short-timeout (fast rate). The DUT always sends LACP PDUs at the slow 30-second interval regardless of the peer's LACP rate setting. This causes test_lag[lacp_rate] to fail with: AssertionError: 30.00 seconds while expected timing is 1 seconds Additionally, the LACP rate mismatch during the failed test leaves the LACP state machine in an inconsistent state, which causes subsequent single_lag test to fail with member ports in deselected state. Skip lacp_rate for Nokia physical platforms, similar to the existing KVM/vsonic skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bing Wang <bingwang@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
added
Request for 202505 branch
Request for 202511 branch
Collaborator
|
This PR has backport request for branch(es): 202505,202511. ---Powered by SONiC BuildBot
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Nokia TH6 hardware does not honor LACP short-timeout (fast rate). The
lacp_ratetest sets the VM neighbor to fast LACP rate (1s) but Nokia TH6 continues to send LACP PDUs at the default 30s slow rate. This causes LACP state inconsistency — the member port gets deselected — makingsingle_lagalso fail.This fix skips
lacp_rateon Nokia physical platforms, following the same pattern as the existing KVM/vsonic skip.Verified: Test body correctly skips for Nokia TH6 (no LACP operations between setup and teardown confirmed via log analysis on
vms13-lt2-nokia-th6-1).Type of change
Back port request
Approach
What is the motivation for this PR?
Nokia TH6 ASIC does not implement LACP short-timeout (fast rate). The hardware ignores LACP fast-rate requests and always sends PDUs at the 30s slow rate. This causes the
lacp_ratetest to fail and, as a side effect, also causessingle_lagto fail due to the resulting LACP state inconsistency.How did you do it?
Added a platform check
any('nokia' in dut.facts.get('platform', '').lower() for dut in duthosts)inside thetestcase == 'lacp_rate'guard, following the same pattern as the existing vsonic skip.How did you verify/test it?
Ran
test_lag[...|PortChannel352-lacp_rate]onvms13-lt2-nokia-th6-1(Nokia IXR7220 H6,Nokia-IXR7220-H6-O256). Confirmed via test logs that test setup ran, the Nokia skip was triggered immediately (no LACP operations logged between setup and teardown), and test teardown ran.Any platform specific information?
Nokia TH6 (
Nokia-IXR7220-H6-O256,x86_64-nokia_ixr7220_h6_128-r0) withplatform_asic=broadcom. Platform is detected via'nokia' in dut.facts['platform'].lower().Supported testbed topology if it is a new test case?
N/A
Documentation