Skip to content

[xcvrd] Optimize module initialization performance#611

Merged
prgeor merged 1 commit into
sonic-net:masterfrom
Junchao-Mellanox:master-xcvrd-optimize
May 19, 2025
Merged

[xcvrd] Optimize module initialization performance#611
prgeor merged 1 commit into
sonic-net:masterfrom
Junchao-Mellanox:master-xcvrd-optimize

Conversation

@Junchao-Mellanox

@Junchao-Mellanox Junchao-Mellanox commented May 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

  1. Use hget instead of hgetall to gain better performance
  2. Optimize SfpStateUpdateTask.init:
  • Use cache in this function for different logical ports with the same physical module.
  • Handles transceiver info table and media settings before any other table.

Motivation and Context

Improve module initialization performance. Due my test:

  1. hget is 7 times faster than hgetall when getting cmis module state
  2. Before optimizing SfpStateUpdateTask.init, the last module takes about 5 minutes to finish notify_media_settings call; after the optimization, the last module takes about 1 minutes to finish notify_media_settings` call.

How Has This Been Tested?

Manual test

Additional Information (Optional)

@mssonicbld

mssonicbld commented May 8, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft May 8, 2025 02:59
@azure-pipelines

azure-pipelines Bot commented May 8, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

mssonicbld commented May 9, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox force-pushed the master-xcvrd-optimize branch from d4413b7 to 474a0e7 Compare May 9, 2025 07:08
@mssonicbld

mssonicbld commented May 9, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

mssonicbld commented May 9, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

mssonicbld commented May 9, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox requested review from keboliu, mihirpat1 and prgeor and removed request for mihirpat1 May 9, 2025 10:11
@Junchao-Mellanox Junchao-Mellanox force-pushed the master-xcvrd-optimize branch from 99bcda1 to d99a906 Compare May 9, 2025 10:19
@mssonicbld

mssonicbld commented May 9, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented May 9, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review May 9, 2025 10:26
@liat-grozovik

liat-grozovik commented May 10, 2025

Copy link
Copy Markdown
Collaborator

@mihirpat1 @prgeor kindly hep to review and comment on this PR

prgeor
prgeor reviewed May 12, 2025
View reviewed changes

@prgeor prgeor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mihirpat1 can you review?

prgeor
prgeor requested changes May 12, 2025
View reviewed changes

@prgeor prgeor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Junchao-Mellanox please provide more details on the 2 optimization. What is the current perf number vs new with this change

@Junchao-Mellanox

Junchao-Mellanox commented May 13, 2025

Copy link
Copy Markdown
Collaborator Author

@Junchao-Mellanox please provide more details on the 2 optimization. What is the current perf number vs new with this change

Updated in description

@Junchao-Mellanox

Junchao-Mellanox commented May 15, 2025

Copy link
Copy Markdown
Collaborator Author

Hi @prgeor , could you please help merge?

@prgeor prgeor merged commit 45c1582 into sonic-net:master May 19, 2025
5 checks passed
@r12f

r12f commented May 21, 2025

Copy link
Copy Markdown

hi @Junchao-Mellanox , do you mind to help create a manual pick to 202412?

@Junchao-Mellanox Junchao-Mellanox deleted the master-xcvrd-optimize branch May 21, 2025 03:47
Junchao-Mellanox added a commit to Junchao-Mellanox/sonic-platform-daemons that referenced this pull request May 21, 2025
@Junchao-Mellanox
[xcvrd] Optimize module initialization performance (sonic-net#611)
240bba7
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request May 21, 2025
Merged
@Junchao-Mellanox

Junchao-Mellanox commented May 21, 2025

Copy link
Copy Markdown
Collaborator Author

hi @Junchao-Mellanox , do you mind to help create a manual pick to 202412?

PR ready: Azure/sonic-platform-daemons.msft#16

@r12f

r12f commented May 22, 2025

Copy link
Copy Markdown

thanks Junchao. It is merged now.

vvolam pushed a commit to vvolam/sonic-platform-daemons that referenced this pull request Jun 16, 2025
@Junchao-Mellanox
[xcvrd] Optimize module initialization performance (sonic-net#611) (s…
5016ded 
…onic-net#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keboliu keboliu keboliu approved these changes

@prgeor prgeor prgeor approved these changes

@mihirpat1 mihirpat1 mihirpat1 approved these changes

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Cherry Pick Conflict_msft-202412 Included in msft-202412 Branch Request for msft-202412 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Junchao-Mellanox @mssonicbld @liat-grozovik @r12f @keboliu @prgeor @mihirpat1 @dgsudharsan