[Smartswitch][chassisd] Addition of pre shutdown and post startup function calls#619
Merged
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| def submit_callback(self, module_index, admin_state): | ||
| if admin_state == MODULE_ADMIN_DOWN: | ||
| try_get(self.chassis.get_module(module_index).module_pre_shutdown, default=False) |
Contributor
There was a problem hiding this comment.
Consider avoiding this call for platforms don't require this. Please add a comment just like the HLD, that this will be applicable to platforms that require entire pcie tree rescan and implemented this function. Otherwise it is a no-op.
Contributor
Author
There was a problem hiding this comment.
Agreed, Added comment mentioning that no actions will be taken on paltforms which do not have the relevant functions implemented. Please check
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rameshraghupathy
approved these changes
May 30, 2025
vvolam
approved these changes
Jun 2, 2025
rlhui
approved these changes
Jun 2, 2025
Collaborator
|
Cherry-pick PR to 202505: #620 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The pre shutdown and post startup functions are called on DPU admin state change operations
How Has This Been Tested?
Additional Information (Optional)