Parse args with standard getopt() instead of custom cli module#83
Closed
slook wants to merge 1 commit intosoulfind-dev:masterfrom
Closed
Parse args with standard getopt() instead of custom cli module#83slook wants to merge 1 commit intosoulfind-dev:masterfrom
slook wants to merge 1 commit intosoulfind-dev:masterfrom
Conversation
Member
|
We used getopt in the past, but removed it. See commit 150f4a9 for details. |
Member
Author
|
Thanks. I didn't realize that you had made this decision. This branch is now for experimentation and demonstration purposes only. It's interesting to know that getopts() removes each argument that is parses because it's good practice to not leave parsed args hanging around in the args for no reason. For instance the --database filename, I don't think our cli.arg_parse() removes them even after it's not needed anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is now for experimentation and demonstration purposes only.
This will allow us to do what we want with the new argument options in #81 and #82, we can simply get
--logoption and process strings in a callback option (see number 8 in the documention for relevant examples) or as an spaced split array with arraySep set to" "(see number 6).No new options nor functional changes in this PR as to the invoking the program, it works just the same as before.