Fix missing user_instructions in LongFormContentStrategy prompt params - #288
Open
mrickar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Previously,
LongFormContentStrategy’sprompt_param_composerdid not includeuser_instructionsfromconfig_conversation.As a result, in
podcastfy/content_generator.py, the following line:would overwrite the
user_instructionsinput instead of appending to it.This PR updates the composer to correctly include
user_instructionsfromconfig_conversation, ensuring that the final prompt preserves user-provided instructions along withLONGFORM_INSTRUCTIONS.Impact: