Fix ASGI remote Address handling#341
Open
M-Hassan-Raza wants to merge 2 commits intosoynatan:masterfrom
Open
Conversation
honor the configured header for asgi requests cache request url regex patterns add tests and a readme note
M-Hassan-Raza
changed the title
keep url pattern caching dynamic normalize forwarded ip values replace the white box url test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes ASGI request logging honor DJANGO_EASY_AUDIT_REMOTE_ADDR_HEADER, matching the existing WSGI behavior.
It also cleans up the request signal a bit by precompiling URL regex patterns and splitting the request metadata logic into small helpers.