Add support for proper integration with boring-notch#210
Open
BierDav wants to merge 6 commits into
Open
Conversation
Author
|
@sozercan can you take a lot at this PR real quick? |
Copilot stopped reviewing on behalf of
sozercan due to an error
April 25, 2026 16:47
Contributor
There was a problem hiding this comment.
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 4
Author
|
@sozercan can you try to invoke Copilot? It seems like it doesn't respond to my comments |
Author
|
I've spent some AI tokens, now the issues should be fixed as well as the formatting and linting |
Author
|
@sozercan do you plan to even merge it all? |
| } | ||
|
|
||
| let response = Self.webSocketHandshakeResponse(secWebSocketKey: secWebSocketKey) | ||
| self.sendHTTPResponse(id: connectionID, response) |
Comment on lines
+150
to
+152
| // Check if host represents loopback | ||
| let debugDesc = host.debugDescription | ||
| isLoopback = debugDesc.contains("127.0.0.1") || debugDesc.contains("::1") || debugDesc.contains("localhost") |
|
|
||
| do { | ||
| let parameters = NWParameters.tcp | ||
| parameters.allowLocalEndpointReuse = true |
| do { | ||
| let parameters = NWParameters.tcp | ||
| parameters.allowLocalEndpointReuse = true | ||
| // Constrain listener to loopback interface to prevent unintended network exposure |
Comment on lines
+534
to
+550
| if previous == nil { | ||
| self.broadcastWebSocketJSON(self.playerInfoPayload(type: "PLAYER_INFO", snapshot: snapshot)) | ||
| } | ||
|
|
||
| if previous?.videoId != snapshot.videoId { | ||
| self.broadcastWebSocketJSON(self.playerInfoPayload(type: "VIDEO_CHANGED", snapshot: snapshot)) | ||
| // Some clients only refresh now-playing metadata on PLAYER_INFO. | ||
| self.broadcastWebSocketJSON(self.playerInfoPayload(type: "PLAYER_INFO", snapshot: snapshot)) | ||
| } | ||
|
|
||
| if previous?.isPaused != snapshot.isPaused { | ||
| self.broadcastWebSocketJSON(self.playerInfoPayload(type: "PLAYER_STATE_CHANGED", snapshot: snapshot)) | ||
| } | ||
|
|
||
| if previous?.title != snapshot.title || previous?.artist != snapshot.artist || previous?.album != snapshot.album { | ||
| self.broadcastWebSocketJSON(self.playerInfoPayload(type: "PLAYER_INFO", snapshot: snapshot)) | ||
| } |
Comment on lines
+67
to
+71
| self.listener?.cancel() | ||
| for state in self.connections.values { | ||
| state.connection.cancel() | ||
| } | ||
| self.monitorTask?.cancel() |
Owner
|
@BierDav do you know when TheBoredTeam/boring.notch#1193 might be merged? I don’t use Boring Notch myself, so it’s a bit harder for me to prioritize |
Author
|
It is a bit of a deadlock situation, currently 😅 but considering that boring.notch is the bigger project it would make sense to me to merge it here first. Additionally the change in boring notch is very small. It basically only consists of adding the bundle id of kaset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-04-22.at.07.36.49.mov
Mind that this PR relies on TheBoredTeam/boring.notch#1193 and vice versa