Predict Handcuffs Component#43679
Open
SirWarock wants to merge 2 commits intospace-wizards:masterfrom
Open
Conversation
PJBot
added
S: Untriaged
Contributor
Author
|
Never name your commits "Fix". You invite test fails. |
Pok27
added
P3: Standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
I predicted the HandCuffs component.
There was an issue with it where uncuffing yourself would create no sound, because the
Usedfield was never updated on the clientside, but the client-side sound wouldn't fire ifUsedwas false.Also, since I was there, I fixed the
IsServer()check by replacing them with predictedqueueDel and PredictedSpawnAt.The overlay however is not yet predicted. (The sprite of the Urist being cuffed even though the cuffs are gone already)
Fixes #15896
Why / Balance
Bugfix + Prediction.
Technical details
Just code clean up really.
Media
Requirements
Breaking changes
Changelog
🆑