Allow toggling Cooldown through ActionEvent#43680
Open
SirWarock wants to merge 1 commit intospace-wizards:masterfrom
Open
Allow toggling Cooldown through ActionEvent#43680SirWarock wants to merge 1 commit intospace-wizards:masterfrom
SirWarock wants to merge 1 commit intospace-wizards:masterfrom
Conversation
PJBot
added
S: Untriaged
Pok27
added
P3: Standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
I added a boolean that decides whether the action cooldown is meant to start or not.
Why / Balance
This allows for custom cooldowns. I have an action downstream that depends on the situation before it does something.
Depending on what situation it's pressed, the cooldown could be longer. However, for that, I have to modify the UseDelay because the cooldown would always be set back to the normal UseDelay when it exits my code, despite me using SetCooldown in my code.
Technical details
Just one itsy boolean.
Media
Requirements
Breaking changes
Changelog