Fixes in TargetOutlineSystem#43688
Open
Dirius77 wants to merge 2 commits intospace-wizards:masterfrom
Open
Conversation
PJBot
added
S: Untriaged
Pok27
added
T: Bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Made some cleanups in TargetOutlineSystem similar to those in #43303
Also made it so that the TargetOutlineSystem queries Dynamic entities as well, allowing the highlighting to also match, for example, mobs that would be valid targets.
Why / Balance
It's really nice for things like the Dragon's devour to also correctly highlight mobs that can be devoured.
Technical details
Made range nullable and squared it so that the range check is more accurate.
Added the
LookupFlags.Dynamicto theGetEntitiesIntersectingcheck so that it also returns items and mobs.Media
Here's a dragon devour actually highlighting a downed corpse now.
https://github.com/user-attachments/assets/f9c1f97b-640f-46aa-b754-1b5ab43aa9d3
Requirements
Breaking changes
TargetOutlineSystem.Enable now takes a nullable float as range. Use this instead of -1 to disable range checks.
Changelog