Refactor RecipeManager to use LINQ and PrototypesReloaded

Content.Shared/Kitchen/RecipeManager.cs

@@ -1,46 +1,32 @@
-using System.Linq;
+using System.Linq;
 using Robust.Shared.Prototypes;
 
-namespace Content.Shared.Kitchen
-{
-    public sealed class RecipeManager
-    {
-        [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
+namespace Content.Shared.Kitchen;
 
-        public List<FoodRecipePrototype> Recipes { get; private set; } = new();
+public sealed class RecipeManager
+{
+    [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
 
-        public void Initialize()
-        {
-            Recipes = new List<FoodRecipePrototype>();
-            foreach (var item in _prototypeManager.EnumeratePrototypes<FoodRecipePrototype>())
-            {
-                if (!item.SecretRecipe)
-                    Recipes.Add(item);
-            }
+    public List<FoodRecipePrototype> Recipes { get; private set; } = new();
 
-            Recipes.Sort(new RecipeComparer());
-        }
-        /// <summary>
-        /// Check if a prototype ids appears in any of the recipes that exist.
-        /// </summary>
-        public bool SolidAppears(string solidId)
-        {
-            return Recipes.Any(recipe => recipe.IngredientsSolids.ContainsKey(solidId));
-        }
+    public void Initialize()
+    {
+        ReloadRecipes();
+        _prototypeManager.PrototypesReloaded += OnPrototypesReloaded;
+    }
 
-        private sealed class RecipeComparer : Comparer<FoodRecipePrototype>
-        {
-            public override int Compare(FoodRecipePrototype? x, FoodRecipePrototype? y)
-            {
-                if (x == null || y == null)
-                {
-                    return 0;
-                }
+    private void OnPrototypesReloaded(PrototypesReloadedEventArgs args)
+    {
+        if (args.WasModified<FoodRecipePrototype>())
+            ReloadRecipes();
+    }
 
-                var nx = x.IngredientCount();
-                var ny = y.IngredientCount();
-                return -nx.CompareTo(ny);
-            }
-        }
+    private void ReloadRecipes()
+    {
+        Recipes = _prototypeManager
+            .EnumeratePrototypes<FoodRecipePrototype>()
+            .Where(x => !x.SecretRecipe)
+            .OrderByDescending(x => x.IngredientCount())
+            .ToList();
     }
 }