Open
Conversation
PJBot
added
S: Untriaged
Pok27
added
P3: Standard
iaada
requested changes
Apr 24, 2026
Member
iaada
left a comment
iaada
left a comment
There was a problem hiding this comment.
Revenant system is a mess but we don't need to fix it all at once. Fixing up corporeal is a good step forward.
Comment on lines
+49
to
+50
| _physics.SetCollisionMask(args.Target, fixture.Key, fixture.Value, (int) (CollisionGroup.SmallMobMask | CollisionGroup.GhostImpassable), fixtures); | ||
| _physics.SetCollisionLayer(args.Target, fixture.Key, fixture.Value, (int) CollisionGroup.SmallMobLayer, fixtures); |
Member
There was a problem hiding this comment.
Hardcoding these collision groups feels wrong. If we move them to the component it's possible this status effect can find a use beyond just Revenant and be given a more generic name. Though resetting the collision groups is tricky, especially while accounting for the possibility of having multiple of the same component at the same time.
I can't think of a great solution.
| public virtual void OnApplied(Entity<CorporealStatusEffectComponent> ent, ref StatusEffectAppliedEvent args) | ||
| { | ||
| _appearance.SetData(uid, RevenantVisuals.Corporeal, true); | ||
| _appearance.SetData(args.Target, RevenantVisuals.Corporeal, true); |
Member
There was a problem hiding this comment.
I feel the same way about the appearance data as I do the collision groups. I'd love to find a more generic solution but I'm drawing a blank.
Contributor
Author
There was a problem hiding this comment.
I'd prefer to leave it until the revenant system is refactored
PJBot
added
S: Awaiting Changes
TheShuEd
reviewed
Apr 24, 2026
PJBot
added
size/M
github-actions
Bot
added
the
S: Merge Conflict
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
Bot
removed
the
S: Merge Conflict
PJBot
added
S: Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Converts
Corporealinto new status effects.Why / Balance
#38575
Technical details
Corporeal visibility is now handled through a refresh-based status effect flow instead of directly changing
VisibilityComponenton apply/remove. I addedVisibilityModifierStatusComponentwithaddVisibilityandremoveVisibilityfields so status effects define their visibility changes declaratively.VisibilityModifierStatusSystemrefreshes visibility by relayingRefreshVisibilityModifiersEventto all active status effects and recomputing the final mask from their combined modifiers. I also addedVisibilityModifierStatusTrackerComponentto preserve the baseline visibility between refreshes, andRevenantSystem.MakeVisible()now resets that baseline after manual visibility changes.StatusEffectCorporealuses the new component.Media
Requirements
Breaking changes
The
Corporealstatus effect has been removed and replaced withStatusEffectCorporealfor the new status effect system.The
CorporealComponenthas been removed and replaced withCorporealStatusEffectComponentChangelog