Open
Conversation
Samuka-C
requested review from
ArtisticRoomba,
Emisse and
spanky-spanky
as code owners
PJBot
added
S: Untriaged
Samuka-C
added
P3: Standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Deleted the PowerSwitchableComponent and replaced it with the VoltageTogglerComponent
Why / Balance
This is necessary for #43455
Technical details
Is mostly a rename of the original component, but now it raises a event when the voltage is changed
then PowerConsumer and PowerSupplier listen to that event to change their voltages
Media
no need
Requirements
Breaking changes
Deleted the PowerSwitchableComponent and systems, replace with VoltageTogglerComponent.
Changelog
no cl, no fun