Merged
Conversation
This commit changes `node save` to accept a filename argument (similar to `list save`) instead of simply saving to the home directory. It also changes `node list` to a simple alias, instead of having 2 very similar commands.
src/known_hosts.c
Outdated
| } | ||
|
|
||
| for (host_t* host = SLIST_FIRST(&known_hosts); host != NULL; host = SLIST_NEXT(host, next)) { | ||
| for (host_t* host = SLIST_FIRST(&known_hosts); host != NULL; host = SLIST_NEXT(host, next)) { |
Contributor
There was a problem hiding this comment.
I don't think this space is required :D
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks!
Some of them actually came from param_list_slash.c
troelsjessen
approved these changes
Mar 21, 2025
something something `__attribute__((cleanup(...)))`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
node saveto accept a filename argument (similar tolist save) instead of simply saving to the home directory.It also changes
node listto a simple alias, instead of having 2 very similar commands.It seems to me that these commands simply haven't kept up with our new preference for using project/mission directories. Hence why they assume a global list in the home directory.