Open
Conversation
alalazo
reviewed
Feb 23, 2026
| key = f"{platform.system()}-{platform.machine()}" | ||
| pkg = packages.get(key) | ||
| if pkg: | ||
| version(ver, sha256=pkg[0], expand=False) |
Member
There was a problem hiding this comment.
A way to deprecate could be:
Suggested change
| version(ver, sha256=pkg[0], expand=False, deprecated=<some expression>) |
The expression imo should be the simplest thing that works, given the deprecation pattern.
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, let me try that.
I think if a version is from 2020 it can be deprecated?
https://github.com/conda-forge/miniforge/releases/tag/4.8.3-4
Contributor
Author
There was a problem hiding this comment.
Maybe something like this:
for _version, packages in _versions.items():
key = f"{platform.system()}-{platform.machine()}"
pkg = packages.get(key)
if pkg:
major = int(_version.split(".")[0])
version(_version, sha256=pkg[0], expand=False, deprecated=major<20)I need some help with the expression here. It works for the given examples, but feels a bit fragile.
Contributor
Author
There was a problem hiding this comment.
Not sure how to proceed. Should I close this?
afuetterer
force-pushed
the
miniforge3-26.1.0-0
branch
from
24184f7 to
4107983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds 26.1.0-0 of miniforge3.
Question: Is the defintion of versions in the dict necessary? miniforge comes via a shell script from GitHub, the exact URL is constructed via
url_for_version, e.g.Ref: https://github.com/conda-forge/miniforge/releases/tag/26.1.0-0
With this approach there is no way of deprecating older versions, right?
What do you think?