arrow on darwin: patch libtool version check to match newer apple output#4153
Merged
rbberger merged 1 commit intospack:developfrom Apr 7, 2026
Merged
Conversation
Contributor
Author
|
@adamjstewart rightly point out that we should raise this on arrow's repo. So, let us not merge this yet. Update: fixed here |
Member
|
Yeah, makes sense to instead use that patch from the MR. Also, there seems to be newer versions. |
336d2ed to
c29c559
Compare
Contributor
Author
|
@spackbot fix style |
|
Let me see if I can fix that for you! |
|
I was able to run spack style --fixrepos/spack_repo/builtin/packages/arrow/package.py
repos/spack_repo/builtin/packages/raja_perf/package.py
�[1;34m==> �[0mrunning flake8
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
�[1;34m==> �[0mstyle checks passed
I've updated the branch with style fixes. |
rbberger
reviewed
Apr 7, 2026
44d2997 to
5c2d543
Compare
fdd5fb4 to
7d0e9a5
Compare
Contributor
Author
|
All CI is green. Let's merge unless there are objections! |
rbberger
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrow package: update
libtool -Vvalidation to match what is given in newer ApplelibtoolFixes CI failure issue seen on recent develop pipeline:
CC @rbberger