Fix incorrectly categorized Ecto spans#33
Open
mrz wants to merge 1 commit intospandex-project:masterfrom
Open
Conversation
|
Hello, @mrz! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use Spandex to send traces to Datadog in two different Elixir projects, using
spandex_phoenixandspandex_ectoin conjunction withspandex_datadog. I've noticed that there are some database spans that are incorrectly categorized as Web spans in the spans view, and I've traced the issue back to howspandex_ectocreates the spans. You can see the problem in these screenshots:As you can see, the first screenshot is showing the Web spans for a trace in Datadog with some Ecto operations. Those are the
queue,run_queryanddecodespans. Switching to the DB spans shows the same operation, but this time it's thequeryspan.This PR aims to correct this small inconvenience.