Add fixed shape tensor#18
Merged
JohanMabille merged 18 commits intoJan 7, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Arrow canonical extension type arrow.fixed_shape_tensor, which enables storing fixed-shape tensors in Arrow format. The implementation follows the Apache Arrow specification for fixed shape tensor arrays.
Key Changes
- Introduces
fixed_shape_tensor_arrayclass wrappingfixed_sized_list_arraywith tensor-specific metadata - Implements JSON serialization/deserialization for tensor metadata (shape, dimension names, permutation)
- Replaces nlohmann_json dependency with simdjson for improved JSON parsing performance
- Adds comprehensive test coverage with 752 lines of tests
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| include/sparrow_extensions/fixed_shape_tensor.hpp | Defines the fixed_shape_tensor_array class and metadata structures with comprehensive documentation |
| src/fixed_shape_tensor.cpp | Implements metadata validation, JSON serialization, and array construction logic |
| tests/test_fixed_shape_tensor.cpp | Provides extensive test coverage for metadata operations, array construction, and spec compliance |
| cmake/external_dependencies.cmake | Adds simdjson dependency and updates doctest version |
| environment-dev.yml | Replaces nlohmann_json with simdjson in conda dependencies |
| CMakeLists.txt | Registers new source files and headers in build system |
| include/sparrow_extensions.hpp | Includes the new fixed_shape_tensor header in main library header |
| tests/CMakeLists.txt | Adds test file to test suite |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
JohanMabille
reviewed
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Alex-PLACET
force-pushed
the
add_fixed_shape_tensor
branch
from
January 6, 2026 15:49
6011091 to
e518d22
Compare
Collaborator
Author
|
I add some fixes on the variable shape tensor as the layout concept satisfaction was missing |
JohanMabille
approved these changes
Jan 7, 2026
Contributor
|
The failure on OSX are unrelated to the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.