Add variable shape tensor#19
Merged
JohanMabille merged 7 commits intoJan 6, 2026
Merged
Conversation
Alex-PLACET
marked this pull request as ready for review
December 24, 2025 10:53
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the Variable Shape Tensor Array extension following the Apache Arrow canonical extension specification. The implementation allows efficient storage and transfer of multi-dimensional tensors with varying shapes.
Key changes include:
- Addition of
variable_shape_tensor_arrayclass with metadata serialization/deserialization - Implementation of Arrow extension metadata handling and validation
- Migration from nlohmann_json to simdjson for improved JSON parsing performance
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_variable_shape_tensor.cpp | Comprehensive test suite for metadata validation, JSON serialization, and round-trip operations |
| tests/CMakeLists.txt | Registers new test file in the build system |
| src/variable_shape_tensor.cpp | Core implementation of metadata, serialization, and array construction |
| include/sparrow_extensions/variable_shape_tensor.hpp | Header defining public API and template implementations |
| include/sparrow_extensions.hpp | Adds variable_shape_tensor header to main include |
| environment-dev.yml | Updates dependency from nlohmann_json to simdjson |
| docs/source/variable_shape_tensor_array.md | Comprehensive documentation with usage examples and API reference |
| docs/source/main_page.md | Adds documentation link for fixed_shape_tensor_array |
| cmake/external_dependencies.cmake | Adds simdjson dependency configuration |
| CMakeLists.txt | Registers variable_shape_tensor.cpp in build sources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JohanMabille
reviewed
Jan 5, 2026
JohanMabille
reviewed
Jan 6, 2026
JohanMabille
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.