Update CaravanMultisig.java#1413
Open
jevidon wants to merge 4 commits into
Open
Conversation
Sparrow currently makes an assumption about the derivation path to replace the "UNKNOWN" masked derivation path. Changing this to m/0/0/0/0 matches the masking provided in the Coldcard multisig config file, ensuring users are able to sign transactions without being rejected by Coldcard for a derivation path mismatch.
Reversing changes to original PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparrow currently makes an assumption about the derivation path to replace the
UNKNOWNmasked derivation path. This assumption is incorrect, and should be removed.