explain that multisig signing is unsupported in sign message dialog#2009
Open
PeterXMR wants to merge 1 commit into
Open
explain that multisig signing is unsupported in sign message dialog#2009PeterXMR wants to merge 1 commit into
PeterXMR wants to merge 1 commit into
Conversation
The address validator now returns "Multisig addresses are not supported for signing" when an address parses but its script type isn't allowed for SINGLE_HD. AppController.signVerifyMessage also shows an inline notice on the dialog when the active wallet is multisig.
PeterXMR
force-pushed
the
fix/1717-multisig-sign-message-notice
branch
from
1694350 to
0523823
Compare
PeterXMR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1717.
Two cues for the multisig-cannot-sign case:
SINGLE_HD(and isn'tP2SH, which can still be wrapped single-sig).MessageSignDialog.setNoticeText(String)adds an inline notice at the top of the dialog.AppController.signVerifyMessagepopulates it when the active wallet is multisig and the dialog falls through to verify-only.Three unit tests on the static validator helper.