expand account subtabs vertically when extra space is available#2010
Open
PeterXMR wants to merge 1 commit into
Open
expand account subtabs vertically when extra space is available#2010PeterXMR wants to merge 1 commit into
PeterXMR wants to merge 1 commit into
Conversation
Binds each subtab pref-width to (paneHeight - 20) / tabCount, clamped to [90, 180], so wallets with named accounts get more horizontal room for their labels when there is extra vertical space in the sidebar. Falls back to the previous 90px floor when many tabs are present.
PeterXMR
force-pushed
the
fix/1578-vertical-account-tabs
branch
from
98b74d1 to
19fc5fe
Compare
PeterXMR
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1578.
Binds each subtab's pref-width to
(paneHeight - 20) / tabCount, clamped to[90, 180]. Wallets with 2-4 named accounts now get enough horizontal room for full labels; the 90px floor preserves the existing layout when many tabs are present. Math is inAppController.computeSubTabSize, tested at the boundaries (0/min/max/in-range/zero).Visually verified via an in-process
Node.snapshot()harness against aTabPaneconfigured exactly like the wallet sidebar.