Replace openpnp-capture-java dependency with io.github.doblon8 implementation#2019
Open
doblon8 wants to merge 1 commit into
Open
Replace openpnp-capture-java dependency with io.github.doblon8 implementation#2019doblon8 wants to merge 1 commit into
doblon8 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
org.openpnp:openpnp-capture-javadependency withio.github.doblon8:openpnp-capture-java(https://github.com/doblon8/openpnp-capture-java).The new implementation uses Java's Foreign Function & Memory (FFM) API instead of JNA while providing equivalent functionality.
The native binaries bundled in
io.github.doblon8:openpnp-capture-javawere taken from https://github.com/sparrowwallet/openpnp-capture.Tested on Linux (Debian 13) x86_64 and Windows 10 x86_64.