Make Tester extensible and framework-aware#72
Merged
Conversation
Tester becomes an abstract base shared by framework adapters: SymfonyTester adds Symfony Console I/O, frameworks like laravel-flare extend it for framework-specific pre-checks and entry point info. Adds a daemon-sender recommendation when logs are tested with a non-daemon sender, and enriches the test trace/log/error payloads with realistic command, entry-point and context attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testerbecomes an abstract base shared by framework adapters.SymfonyTesteradds Symfony Console I/O on top, frameworks likespatie/laravel-flareextend it for framework-specific pre-checks and entry-point info.What changed
Testeris abstract;run()orchestrates pre-checks, sending and rendering. Write hooks (writeLine/writeNewline) are abstract and supplied by subclasses.SymfonyTesterwires Symfony Console (InputInterface/OutputInterface) and provides a default CLI entry point.shared/FakeSymfonyTester.phpfor downstream packages that want to test their own subclass against the same harness.STYLE_PLAIN/STYLE_INFO/STYLE_WARNING/STYLE_ERROR) replace the prior level-based naming.DaemonSender.FlareProviderno longer registersTesterin the container (it's abstract now; subclasses are constructed by their owning packages).symfony/consoleadded to require.This PR is a prerequisite for the matching laravel-flare PR which moves
TestCommand's remaining logic into aLaravelTestersubclass.