Fix team scope when syncing role models - #2967
Open
amrachraf6699 wants to merge 1 commit into
Open
Conversation
drbyte
marked this pull request as draft
August 14, 2026 05:09
amrachraf6699
marked this pull request as ready for review
August 23, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Role::syncModels()removing role assignments from every team when teams are enabled.The pivot delete query is now scoped to the active permissions team, matching the behavior of the user-side role synchronization APIs.
Problem
Calling:
previously deleted all assignments for that role, including assignments belonging to other teams.
Fix
Adds the active team constraint to the inverse role-model pivot query used by
syncModels().Tests
Added a regression test confirming that syncing models in team 1 removes only team 1’s assignment and preserves the same role assignment in team 2.
vendor/bin/pest tests/Traits/HasAssignedModelsTest.php --filter="only syncs models for the active team"Passed.