Make role model sync atomic - #2968
Open
amrachraf6699 wants to merge 1 commit into
Open
Conversation
drbyte
marked this pull request as draft
August 14, 2026 05:09
amrachraf6699
marked this pull request as ready for review
August 23, 2026 21:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
Role::syncModels()atomic so a failed attachment cannot remove existing role-to-model assignments.Problem
syncModels()deleted all existing pivot records before attaching the replacement models.When an unsaved model was supplied, the pivot insert failed because the model key was null. The exception was thrown, but the prior assignments had already been deleted.
Fix
Wrap the delete-and-attach sequence in a database transaction.
The original
QueryExceptionstill propagates, but the database rolls back the pivot deletion when attachment fails.Test
Added a regression test covering an unsaved target model:
vendor/bin/pest tests/Traits/HasAssignedModelsTest.php --filter="does not detach models when syncing an unsaved model"Passed.