Conversation
| INPUT_FORCE=true | ||
| RUN_FINALIZE=true | ||
| INPUT_SIGNED_COMMITS=true No newline at end of file | ||
| INPUT_SIGNED_COMMITS=false No newline at end of file |
bflad
left a comment
bflad
left a comment
There was a problem hiding this comment.
Some considerations before making these changes. I'm also not sure that its really scope creep to also do the split commits for signed commits -- I would find it confusing on both sides that the action works differently with respect to split commits based on whether commit signing was enabled.
internal/git/git.go
Outdated
| }{ | ||
| {paths: []string{"**/.speakeasy/", "*gen.yaml", "*gen.lock", "*workflow.yaml", "*workflow.lock"}, msg: "build: Speakeasy config and lock files " + speakeasyVersionSuffix}, | ||
| {paths: []string{"*.md"}, msg: "docs: regenerate markdown files " + speakeasyVersionSuffix}, | ||
| {paths: []string{"."}, msg: "feat: regenerate SDK " + speakeasyVersionSuffix}, |
There was a problem hiding this comment.
This will cause the PR description to be feat: regenerate SDK (v1.234.5) when it previously was ci: regenerated with Speakeasy CLI 1.234.5. I personally think the new description is confusing since there are multiple versions with any given SDK:
- SDK/target version
- OpenAPI document version
- Speakeasy version (and even generator version if we're being pedantic about versions)
The target being rebuilt may also not be an SDK. (Terraform and other internal thing I'm working on 😉)
Maybe best to keep it similar to the old message and consider dropping the CLI and version part?
4 participants
INPUT_SIGNED_COMMITS=falseas it's more commonScreen.Recording.2025-05-07.at.08.27.08.mov