Add stopPlayer method to stop current audio playback#14
Open
inakiabt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to both the Android and iOS audio modules, allowing the audio player to be stopped programmatically from the JavaScript layer. The implementation includes native methods for stopping playback and updates the TypeScript API to expose this functionality.
New stop player functionality:
stopPlayerfunction to the TypeScript API insrc/core.ts, which calls the native module's stop method.stopPlayermethod in the AndroidAudioEngineclass that clears the audio queue, stops playback, and resets the output volume.stopPlayermethod as a callable function in the AndroidExpoTwoWayAudioModuleclass.stopPlayermethod in the iOSAudioEngineclass that stops the speech player and updates the output volume.stopPlayermethod as a callable function in the iOSExpoTwoWayAudioModuleclass.