7.13.0 - #462
Merged
Merged
Conversation
add(n, 'month') (and quarter/season/year) clamps an overflowing day to
the length of the target month, but read the static monthLength table
where February is always 28. So Jan 31 + 1 month landed on Feb 28 even
in leap years:
spacetime('2020-01-31').add(1, 'month') // Feb 28, expected Feb 29
Route the clamp through the existing leap-aware getMonthLength() helper
(now exported from set/_model.js) so February resolves to 29 in leap
years. Common years are unchanged.
fix(add): clamp month arithmetic to the leap-aware month length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7.13.0 [Jun 2026]