fix(parse): support Date.toString() format - #465
Merged
spencermountain merged 1 commit intoJul 13, 2026
Conversation
Strings produced by javascript's Date.toString(), like "Mon Jun 17 2019 11:00:00 GMT-0700 (Pacific Daylight Time)", failed to parse and returned an invalid spacetime. Add a m-d-y parser that accepts a trailing "GMT±HHMM" (or bare "±HHMM") offset followed by an optional "(Time Zone Name)" suffix. Closes spencermountain#148
Owner
|
thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Strings produced by JavaScript's
Date.toString(), like"Mon Jun 17 2019 11:00:00 GMT-0700 (Pacific Daylight Time)", failed toparse and returned an invalid spacetime.
Fix
Add an m-d-y parser that accepts a trailing
GMT±HHMM(or bare±HHMM)offset followed by an optional
(Time Zone Name)suffix. The weekday isalready stripped by normalize, so the parser matches the
Month Day Year Time Offsetshape and applies the offset and time.Testing
Added
test/tostring-parse.test.jscovering:GMT-0700 (Pacific Daylight Time)GMT+0530 (India Standard Time)GMT+0000 (Coordinated Universal Time)GMTprefix and no timezone nameEach asserts the result is valid and its epoch matches the equivalent ISO
string.
Closes #148