Skip to content

trezor: support Safe 7#10677

Merged
SomberNight merged 2 commits into
spesmilo:masterfrom
romanz:safe7
Jun 29, 2026
Merged

trezor: support Safe 7#10677
SomberNight merged 2 commits into
spesmilo:masterfrom
romanz:safe7

Conversation

@romanz

@romanz romanz commented May 30, 2026

Copy link
Copy Markdown
Contributor

Trezor Safe 7 is using Trezor-Host Protocol, for encrypted and authenticated communication.

Since it requires a pairing process before device features are available, an additional WCTrezorPair wizard step is introduced, allowing the user to enter 6-digit pairing code (as shown on the device).

TODOs:

Comment thread electrum/plugins/trezor/qt.py
Comment thread electrum/plugins/trezor/qt.py Outdated
@romanz romanz marked this pull request as ready for review June 5, 2026 12:11
@romanz romanz marked this pull request as draft June 5, 2026 12:12
@romanz romanz marked this pull request as ready for review June 12, 2026 07:49
@romanz romanz marked this pull request as draft June 17, 2026 10:10
@romanz romanz marked this pull request as ready for review June 19, 2026 15:58
@romanz

romanz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@SomberNight would it be OK to allow cancellation only for non-THP devices (to avoid bumping trezorlib due to trezor/trezor-firmware#7112)?

Asking since the user can cancel the current flow also from the device itself.

Comment thread electrum/plugins/trezor/clientbase.py Outdated
Trezor Safe 7 is using Trezor-Host Protocol, for encrypted and authenticated communication:
https://docs.trezor.io/trezor-firmware/common/thp/specification.html

Since it requires a pairing process before device features are available,
an additional `WCTrezorPair` wizard step is introduced, allowing the user
to enter 6-digit pairing code (as shown on the device).
@romanz

romanz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Squashed fixups into a single commit.

Comment thread electrum/plugins/trezor/qt.py Outdated
@f321x

f321x commented Jun 29, 2026

Copy link
Copy Markdown
Member

Tested with Safe 7 and Safe 3, lgtm.

@SomberNight SomberNight added this to the 4.8.0 milestone Jun 29, 2026
@SomberNight SomberNight merged commit e858b94 into spesmilo:master Jun 29, 2026
11 checks passed
@SomberNight

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants