wallet.check_sighash: don't assume tx.add_info_from_wallet alrdy ran#10729
Merged
Conversation
Sighash warnings/errors might in theory not be triggered for inputs owned by the wallet but which are beyond the gap limit. tx.add_info_from_wallet(wallet) side-effects the wallet state so that wallet.is_mine() learns derivation paths for beyond-gap-limit addresses. In practice both GUIs currently call tx.add_info_from_wallet before check_sighash runs, so this was not exploitable.
SomberNight
added
the
topic-wallet 👛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sighash warnings/errors might in theory not be triggered for inputs owned by the wallet but which are beyond the gap limit.
tx.add_info_from_wallet(wallet)side-effects the wallet state so thatwallet.is_mine()learns derivation paths for beyond-gap-limit addresses.In practice both GUIs currently call
tx.add_info_from_walletbeforecheck_sighashruns, so this was not exploitable.