hww: add a deprecation message popup at get_xpub time for bitbox01 and safe-t - #10871
Open
accumulator wants to merge 2 commits into
Open
hww: add a deprecation message popup at get_xpub time for bitbox01 and safe-t#10871accumulator wants to merge 2 commits into
accumulator wants to merge 2 commits into
Conversation
accumulator
force-pushed
the
hww_deprecation_bb01_archos
branch
from
August 26, 2026 07:15
7fc55b3 to
de88145
Compare
Member
|
Is the reason this is draft that you cannot test it as you lack the hardware? If so, say so, and I will try to test it. I have both but have not plugged them in for a long while. |
SomberNight
reviewed
Aug 29, 2026
Comment on lines
+139
to
+146
| deprecation_warning = ( | ||
| "DigitalBitbox (BitBox01) is being deprecated.\n\nIt is no longer supported by the manufacturer.\n" | ||
| "Future versions of Electrum will no longer be compatible with it.\n\n" | ||
| "You should move your coins and migrate to a modern hardware device.") | ||
| _logger.warning(deprecation_warning.replace("\n", " ")) | ||
|
|
||
| if self.handler: | ||
| self.handler.show_warning(deprecation_warning, blocking=True) |
Member
There was a problem hiding this comment.
maybe only show this once per process lifecycle?
You could declare a global DEPRECATION_WARNING_SHOWN = False at the top, and set it to true here.
Member
Author
I have a bitbox01, but no safe-t. |
…d safe-t this adds a show_warning() method on the hardware handler interface, similar to show_error()
accumulator
force-pushed
the
hww_deprecation_bb01_archos
branch
from
August 31, 2026 16:40
de88145 to
4dfe946
Compare
accumulator
marked this pull request as ready for review
August 31, 2026 16:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
popup at
get_xpub()seems most convenient, since this reports to user at wallet creation time, and at existing wallet pairing time.