lnworker: add sanity check to trampoline forwarding - #10902
Open
SomberNight wants to merge 1 commit into
Open
Conversation
These new asserts should not be triggered unless there are bugs in the code. Which there are. (still the asserts are not intended as primary checks, just defense-in-depth)
SomberNight
force-pushed
the
202608_trampoline_fwd_sanity_check
branch
from
August 27, 2026 16:56
8527509 to
4cca7da
Compare
ecdsa
reviewed
Aug 31, 2026
| f"RHASH corresponds to payreq we created. {payment_hash.hex()=}") | ||
| raise OnionRoutingFailure(code=OnionFailureCode.TEMPORARY_NODE_FAILURE, data=b'') | ||
|
|
||
| assert total_msat >= amt_to_forward # sanity check: money_in >= money_out |
Member
There was a problem hiding this comment.
maybe add closest_inc_cltv_abs >= out_cltv_abs ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These new asserts should not be triggered unless there are bugs in the code.
Which there are.
(still the asserts are not intended as primary checks, just defense-in-depth)