Qt6 by accumulator · Pull Request #8545 · spesmilo/electrum

accumulator · 2023-07-19T12:46:02Z

Currently builds a working APK using buildozer HEAD and python-for-android HEAD plus a patchset for qt6 bootstrap and pyqt6.

Builds against API 31, NDK 23c

Additional notes:

~~build container name temporarily renamed so it's easier to switch between current qt5 and this qt6 build~~
bootstrap now requires a native qt6 build in order to provide tooling and cmake files for android target. This currently cannot be done using distribution provided qt6. This will increase build time.
the p4a patchset disables NDK version check, as qt6.4.3 officially supports NDK23, while p4a demands NDK25. I've encountered no obvious problems with using NDK23
when testing on desktop, note that Pillow dependency is upped to 8.4.0 for PyQt6 support

Issues

Camera is unstable in Qt 6.4 and 6.5. Resolved for now, by using SimpleScannerActivity on android platform.
UI doesn't always resize correctly in case the keyboard is visible.

taken from #8545 22bfd4e note: com.android.support is used in our p4a fork's PythonActivity.java (com.android.support was previously pulled in by me.dm7.barcodescanner) https://github.com/accumulator/python-for-android/blob/052b9f7945bae557347fa4a4b418040d9da9eaff/pythonforandroid/bootstraps/qt5/build/src/main/java/org/kivy/android/PythonActivity.java#L43

accumulator · 2023-10-31T14:59:50Z

removing Draft status, as there are currently no open issues and this PR can be reviewed as is.

before considering merging, the build container name change commit should be removed first.

…dd tomli recipe

buildozer ref to 698b48136c55b2495128207c5e98dccc128bb6c2

…dicators toggle visibility

As the method of capturing frames is totally different, the animation when a QR is found has been removed.

…ith simple properties

for QR code scanning with camera https://github.com/spesmilo/electrum/blob/1c10b1ce00aa3621a229bc9fe05d3aeb2ace7da5/electrum/gui/kivy/data/java-classes/org/electrum/qr/SimpleScannerActivity.java

…y for android only. Also use stable R package, regardless of APP_PACKAGE_DOMAIN used in build.

turns out that Qt.inputMethod.keyboardRectangle.height is not suitable for calculating the exact keyboard dimensions in Qt coordinates. Instead, use Qt.inputMethod.keyboardRectangle.y transformed to Qt coordinates using Screen.devicePixelRatio Note: Qt.inputMethod.keyboardRectangle stop being updated after exiting FLAG_SECURE state (e.g. in seed or master key entry pages)

accumulator · 2023-11-07T09:33:56Z

rebased and removed the commit changing the qt6 specific build image name, so this PR should be ready to merge.

(build container name change parked in https://github.com/accumulator/electrum/tree/qt6-tmp if you need it)

Doesn't really work as it triggers on events above the background it is defined on :(

SomberNight

I have tried to review and test this now (at commit 047cc6f), and to me it looks good.
Thank you very much for this work.

SomberNight reviewed Jul 19, 2023

View reviewed changes

Comment thread electrum/gui/qml/components/About.qml

SomberNight reviewed Jul 19, 2023

View reviewed changes

Comment thread contrib/android/Dockerfile Outdated

SomberNight mentioned this pull request Jul 19, 2023

android build: rebase p4a, rebase buildozer, bump targetSdkVersion #8002

Closed

2 tasks

Khademr7 approved these changes Jul 21, 2023

View reviewed changes

SomberNight reviewed Aug 30, 2023

View reviewed changes

Comment thread contrib/android/buildozer_qml.spec Outdated

SomberNight mentioned this pull request Aug 30, 2023

remove the kivy gui #8591

Merged

ecdsa added this to the 4.5.0 milestone Sep 7, 2023

accumulator force-pushed the qt6 branch 6 times, most recently from 94ba1b2 to 2aa7565 Compare October 2, 2023 15:45

accumulator force-pushed the qt6 branch from a2e9027 to 091518e Compare October 5, 2023 09:25

SomberNight reviewed Oct 5, 2023

View reviewed changes

Comment thread contrib/android/Dockerfile Outdated

SomberNight mentioned this pull request Oct 13, 2023

qml qt6: use ZXing-based camera accumulator/electrum#2

Merged

3 tasks

accumulator force-pushed the qt6 branch 3 times, most recently from ea6fc08 to d4871f7 Compare October 24, 2023 10:36

SomberNight reviewed Oct 24, 2023

View reviewed changes

Comment thread electrum/gui/qml/java_classes/org/electrum/qr/SimpleScannerActivity.java

accumulator force-pushed the qt6 branch from d4871f7 to 49a61a8 Compare October 26, 2023 09:28

SomberNight reviewed Oct 30, 2023

View reviewed changes

Comment thread contrib/android/buildozer_qml.spec Outdated

accumulator marked this pull request as ready for review October 31, 2023 15:00

SomberNight reviewed Oct 31, 2023

View reviewed changes

Comment thread contrib/android/Dockerfile Outdated

SomberNight reviewed Oct 31, 2023

View reviewed changes

Comment thread electrum/gui/qml/android_res/layout/scanner_layout.xml

accumulator added 3 commits November 7, 2023 10:09

qt6: update android build container to bookworm

16d3db9

qt6: update recipe pins, NDK, SDK, Ant, use venv for buildozer/p4a, a…

770a32c

…dd tomli recipe

android: update p4a ref to 3b3733dbf5f461e197ba83887ac0d3b6d0f1c396

bf6163b

buildozer ref to 698b48136c55b2495128207c5e98dccc128bb6c2

accumulator and others added 13 commits November 7, 2023 10:09

qml: exclude payserver plugin for qml

0441cb0

qml: port PyQt5 to PyQt6

6270eae

qml: remove all QML imports version numbers

8b567ae

qml: work around toolbar layout not right-aligning indicators when in…

ae44637

…dicators toggle visibility

qml: qualify all signal handler parameters

65d41cc

qml: refactor qr scan to qt6

a77ff99

As the method of capturing frames is totally different, the animation when a QR is found has been removed.

cirrus: task timeout 90m

e561ce2

qml: android back-gesture conflict hack not working on qt6, replace w…

db532db

…ith simple properties

gui: make common_qt compatible with both Qt5 and Qt6

be801f3

qt6: update buildozer ref to ce4f2257249fdf4ff1f4cb8983fd7ac44174a274

b9ab0f6

android: restore SimpleScannerActivity.java that was used in kivy

c33ee87

for QR code scanning with camera https://github.com/spesmilo/electrum/blob/1c10b1ce00aa3621a229bc9fe05d3aeb2ace7da5/electrum/gui/kivy/data/java-classes/org/electrum/qr/SimpleScannerActivity.java

qml: replace Send/ScanDialog with java bases zxing qr scan activity.

5c3e14d

qml: restore Send/ScanDialog for desktop/dev, keeping qr scan Activit…

32c1915

…y for android only. Also use stable R package, regardless of APP_PACKAGE_DOMAIN used in build.

accumulator force-pushed the qt6 branch from 985c934 to bd9100d Compare November 7, 2023 09:28

accumulator and others added 4 commits November 7, 2023 10:32

android: set target_sdk_version to 33

55c01bd

android: correctly describe buildozer branch used

58ff76a

qml qr scanner: make xml layout look nicer

1544a71

accumulator force-pushed the qt6 branch from bd9100d to 1544a71 Compare November 7, 2023 09:32

accumulator added 2 commits November 7, 2023 17:05

qml: fix issue with width of fiat textedit on ReceiveDetailsDialog

8798a45

qml: remove attempt to unfocus by clicking dialog background

047cc6f

Doesn't really work as it triggers on events above the background it is defined on :(

SomberNight approved these changes Nov 9, 2023

View reviewed changes

SomberNight merged commit 5ba156f into spesmilo:master Nov 9, 2023

accumulator deleted the qt6 branch November 10, 2023 08:35

SomberNight mentioned this pull request Dec 13, 2023

android qt6 build not reproducible #8746

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Qt6#8545

Qt6#8545
SomberNight merged 22 commits into
spesmilo:masterfrom
accumulator:qt6

accumulator commented Jul 19, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

accumulator commented Oct 31, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

accumulator commented Nov 7, 2023 •

edited

Loading

Uh oh!

SomberNight left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

accumulator commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

accumulator commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

accumulator commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SomberNight left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

accumulator commented Jul 19, 2023 •

edited

Loading

accumulator commented Oct 31, 2023 •

edited

Loading

accumulator commented Nov 7, 2023 •

edited

Loading