Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flag.go
Original file line number Diff line number Diff line change
Expand Up @@ -1157,12 +1157,12 @@ func (f *FlagSet) Parse(arguments []string) error {
}
f.parsed = true

f.args = make([]string, 0, len(arguments))

if len(arguments) == 0 {
return nil
}

f.args = make([]string, 0, len(arguments))

set := func(flag *Flag, value string) error {
return f.Set(flag.Name, value)
}
Expand Down
40 changes: 40 additions & 0 deletions flag_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,46 @@ func TestFlagSetParse(t *testing.T) {
testParse(NewFlagSet("test", ContinueOnError), t)
}

func TestParseRepeated(t *testing.T) {
fs := NewFlagSet("test repeated", ContinueOnError)

t.Run("first parse", func(t *testing.T) {
err := fs.Parse([]string{"foo", "bar"})
if err != nil {
t.Fatal("expected no error, got ", err)
}

argsAfterFirst := fs.Args()
if !reflect.DeepEqual(argsAfterFirst, []string{"foo", "bar"}) {
t.Fatalf("expected args [foo bar], got %v", argsAfterFirst)
}
})

t.Run("re-parse with fewer args", func(t *testing.T) {
err := fs.Parse([]string{"baz"})
if err != nil {
t.Fatal("expected no error, got ", err)
}

argsAfterSecond := fs.Args()
if !reflect.DeepEqual(argsAfterSecond, []string{"baz"}) {
t.Fatalf("expected args [baz], got %v", argsAfterSecond)
}
})

t.Run("re-parse with no args", func(t *testing.T) {
err := fs.Parse([]string{})
if err != nil {
t.Fatal("expected no error, got ", err)
}

argsAfterThird := fs.Args()
if !reflect.DeepEqual(argsAfterThird, []string{}) {
t.Fatalf("expected args [], got %v", argsAfterThird)
}
})
}

func TestChangedHelper(t *testing.T) {
f := NewFlagSet("changedtest", ContinueOnError)
f.Bool("changed", false, "changed bool")
Expand Down
Loading