Adjust rst warning directive to a confluence note type#1170
Merged
Conversation
Warning are subjectively a yellow-hinted admonition. While we mapped a reStructuredText warning to a Confluence warning, a Confluence warning type is red-hinted. This commit adjusts the mapping to have warning nodes to now create Confluence note macros. Signed-off-by: James Knight <git@jdknight.me>
Allow advanced users to tailor the mapping of admonition type to Confluence macros used. Signed-off-by: James Knight <git@jdknight.me>
Signed-off-by: James Knight <git@jdknight.me>
An update [1] to adjust warning directives to map to Confluence note types was made. Updating the unit test to handle this. [1]: dbc3660 Signed-off-by: James Knight <git@jdknight.me>
Signed-off-by: James Knight <git@jdknight.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning are subjectively a yellow-hinted admonition. While we mapped a reStructuredText warning to a Confluence warning, a Confluence warning type is red-hinted. This commit adjusts the mapping to have warning nodes to now create Confluence note macros.
This change also introduces an undocumented
confluence_adv_admonition_overridesconfiguration, allowing users to override the mapping between admonition types to Confluence macro types.