Add Ruby EOL information#675
Open
a-chacon wants to merge 5 commits into
Open
Conversation
Collaborator
|
@a-chacon This is super useful, thank you! I agree we definitely want the warning when installing an EOL version, and I do like the table output, too. What is your concern there? Making the table too cluttered again? I also like @indirect's suggestion of showing the time to EOL for supported versions. |
a-chacon
force-pushed
the
add-ruby-eol-information
branch
2 times, most recently
from
b7f92a0 to
ad9135d
Compare
Contributor
Author
|
@deivid-rodriguez yes! I was wondering if this can be much information or missing the real meaning of the command "rv ruby list". But I also like, now it looks like: I leave it as ready for review now ;) |
a-chacon
force-pushed
the
add-ruby-eol-information
branch
from
1b52bfb to
1d9f4b4
Compare
Collaborator
|
@a-chacon Just letting you know that I didn't forget about this, I plan to have a look at it this week and hopefully land it! |
Contributor
Author
|
@deivid-rodriguez good to know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I commented it here #668 , it is just an idea. I think the warning installing a EOL version is good, about the table I am not so sure, I was thinking made it optional, like
rv ruby list --eolor something like that.Let me know you think about it. The code is just a draft for now.