Draft
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
re-enable-tests
branch
from
2efd5f6 to
0c21e2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fibonacci1729 Right now, this fails because the test response body appears empty (when it is expected to be a "Hello world" message). I can't see what I need to change though - my guess is that something needs to flush or wait longer or something, but I thought
collect()would do that for me. Would you mind giving it a once-over to see where my understanding has gone awry please? Thanks (and sorry for loading this on your plate)!