This repository was archived by the owner on Dec 20, 2025. It is now read-only.
fix(core): Unable to list project clusters#5361
Open
jcavanagh wants to merge 1 commit intospinnaker:masterfrom
Open
fix(core): Unable to list project clusters#5361jcavanagh wants to merge 1 commit intospinnaker:masterfrom
jcavanagh wants to merge 1 commit intospinnaker:masterfrom
Conversation
The affected code is attempting to merge image lists from the "same" builds across various clusters. In the case of Kubernetes, the list returned from KubernetesImageSummary is immutable. So, always convert the (maybe) immutable list from the ImageSummary implementation to a regular mutable list. Resolves spinnaker#6149
Contributor
|
The change looks good to me. Would you mind adding a test that demonstrates the bug/fix? |
mattgogerly
approved these changes
Apr 17, 2024
Member
|
@Mergifyio update |
Contributor
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The affected code is attempting to merge image lists from the "same" builds across various clusters. In the case of Kubernetes, the list returned from KubernetesImageSummary is immutable.
So, always convert the (maybe) immutable list from the ImageSummary implementation to a regular mutable list.
Resolves #6149